I do not prefer special comments for one static analyzer. Is there an alternative design/implementation of this code to make it more readable and not trigger any static analysis false positives?
Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ranbir > Singh > Sent: Tuesday, October 3, 2023 10:48 PM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A <hao.a...@intel.com>; Ni, Ray <ray...@intel.com>; > Veeresh Sangolli <veeresh.sango...@dellteam.com> > Subject: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: > Fix MISSING_BREAK Coverity issues > > From: Ranbir Singh <ranbir.sin...@dell.com> > > The function GetNextHidItem has a switch-case code in which the > case 1: falls through to case 2: and then case 2: falls through > to case 3: in the block. > > While this may be intentional, it is not evident to any general > code reader as well as any static analyzer tool. Just adding > > // No break; here as this is an intentional fallthrough. > > as comment in between makes a reader as well as Coverity happy. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4222 > > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Co-authored-by: Veeresh Sangolli <veeresh.sango...@dellteam.com> > Signed-off-by: Ranbir Singh <ranbir.sin...@dell.com> > Signed-off-by: Ranbir Singh <rsi...@ventanamicro.com> > --- > MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c > b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c > index acc19acd98e0..bc9a4824208b 100644 > --- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c > +++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c > @@ -89,6 +89,10 @@ GetNextHidItem ( > return StartPos; > > } > > > > + // > > + // No break; here as this is an intentional fallthrough > > + // > > + > > case 2: > > // > > // 2-byte data > > @@ -99,6 +103,10 @@ GetNextHidItem ( > return StartPos; > > } > > > > + // > > + // No break; here as this is an intentional fallthrough > > + // > > + > > case 3: > > // > > // 4-byte data, adjust size > > -- > 2.34.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#109309): > https://edk2.groups.io/g/devel/message/109309 > Mute This Topic: https://groups.io/mt/101750274/1643496 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kin...@intel.com] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109333): https://edk2.groups.io/g/devel/message/109333 Mute This Topic: https://groups.io/mt/101750274/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
