From: Ranbir Singh <[email protected]>
The function GetNextHidItem has a switch-case code in which the
case 1: falls through to case 2: and then case 2: falls through
to case 3: in the block.
While this may be intentional, it is not evident to any general
code reader as well as any static analyzer tool. Just adding
// No break; here as this is an intentional fallthrough.
as comment in between makes a reader as well as Coverity happy.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4222
Cc: Hao A Wu <[email protected]>
Cc: Ray Ni <[email protected]>
Co-authored-by: Veeresh Sangolli <[email protected]>
Signed-off-by: Ranbir Singh <[email protected]>
Signed-off-by: Ranbir Singh <[email protected]>
---
MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
index acc19acd98e0..bc9a4824208b 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
@@ -89,6 +89,10 @@ GetNextHidItem (
return StartPos;
}
+ //
+ // No break; here as this is an intentional fallthrough
+ //
+
case 2:
//
// 2-byte data
@@ -99,6 +103,10 @@ GetNextHidItem (
return StartPos;
}
+ //
+ // No break; here as this is an intentional fallthrough
+ //
+
case 3:
//
// 4-byte data, adjust size
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109309): https://edk2.groups.io/g/devel/message/109309
Mute This Topic: https://groups.io/mt/101750274/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
