On Fri, Jan 27, 2023 at 10:02 AM Marvin Häuser <mhaeu...@posteo.de> wrote: > > On 27. Jan 2023, at 10:29, Savva Mitrofanov <savva...@gmail.com> wrote: > > > > Missing comparison != 0 leads to broken logic condition. > > The actual issue appears to be FeaturesCompat vs FeaturesRoCompat (latter is > hidden by your usage of the macro). Checking for != 0 is redundant (albeit > required by the code style guideline for non-functional reasons). Please > confirm and update the commit message if you agree.
+1, the actual issue comes from using the wrong feature mask and not the != 0. If we get a v4, please update, else I can rewrite it myself. Reviewed-by: Pedro Falcato <pedro.falc...@gmail.com> -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99172): https://edk2.groups.io/g/devel/message/99172 Mute This Topic: https://groups.io/mt/96562691/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
