On Fri, Jan 27, 2023 at 9:29 AM Savva Mitrofanov <savva...@gmail.com> wrote:
>
> Superblock s_inodes_per_group field can't be zero, it leads to division
> by zero in BlockGroup routine Ext4ReadInode
>
> Cc: Marvin Häuser <mhaeu...@posteo.de>
> Cc: Pedro Falcato <pedro.falc...@gmail.com>
> Cc: Vitaly Cheptsov <vit9...@protonmail.com>
> Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.")
> Signed-off-by: Savva Mitrofanov <savva...@gmail.com>
> ---
> Features/Ext4Pkg/Ext4Dxe/Superblock.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c
> b/Features/Ext4Pkg/Ext4Dxe/Superblock.c
> index 35dcf3c007c8..be3527e4d618 100644
> --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c
> +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c
> @@ -243,6 +243,11 @@ Ext4OpenSuperblock (
>
> DEBUG ((DEBUG_FS, "Read only = %u\n", Partition->ReadOnly));
>
> + if (Sb->s_inodes_per_group == 0) {
> + DEBUG ((DEBUG_ERROR, "[ext4] Inodes per group can not be zero\n"));
> + return EFI_VOLUME_CORRUPTED;
> + }
> +
> Partition->BlockSize = (UINT32)LShiftU64 (1024, Sb->s_log_block_size);
>
> // The size of a block group can also be calculated as 8 *
> Partition->BlockSize
> --
> 2.39.0
>
Reviewed-by: Pedro Falcato <pedro.falc...@gmail.com>
--
Pedro
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99161): https://edk2.groups.io/g/devel/message/99161
Mute This Topic: https://groups.io/mt/96562692/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
