Ray, I have given my reviewed-by for the whole patch set. https://edk2.groups.io/g/devel/message/85499?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3A created%2C0%2Ccorresponding%2C20%2C2%2C20%2C88339058
Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ni, Ray > 发送时间: 2022年2月10日 13:37 > 收件人: Gao, Liming <gaolim...@byosoft.com.cn>; Wang, Jian J > <jian.j.w...@intel.com> > 抄送: Bi, Dandan <dandan...@intel.com>; Lou, Yun <yun....@intel.com>; > devel@edk2.groups.io > 主题: Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: Replace Opcode with > the corresponding instructions. > > Reviewed-by: Ray Ni <ray...@intel.com> > > Liming, Jian, can you give R-b as the package maintainers? > > -----Original Message----- > From: Lou, Yun <yun....@intel.com> > Sent: Monday, January 10, 2022 11:13 PM > To: devel@edk2.groups.io > Cc: Lou, Yun <yun....@intel.com>; Ni, Ray <ray...@intel.com>; Bi, Dandan > <dandan...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn> > Subject: [PATCH v2 1/6] MdeModulePkg: Replace Opcode with the > corresponding instructions. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 > > Replace Opcode with the corresponding instructions. > The code changes have been verified with CompareBuild.py tool, which > can be used to compare the results of two different EDK II builds to > determine if they generate the same binaries. > (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) > > Signed-off-by: Jason Lou <yun....@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Dandan Bi <dandan...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > --- > MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm | 20 > +++---------------- > MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm | 21 > +++----------------- > 2 files changed, 6 insertions(+), 35 deletions(-) > > diff --git > a/MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm > b/MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm > index cfb418748f..07fc912fe8 100644 > --- a/MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm > +++ b/MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm > @@ -1,7 +1,7 @@ > ;/** @file > > ; Low leve IA32 specific debug support functions. > > ; > > -; Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR> > > +; Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR> > > ; SPDX-License-Identifier: BSD-2-Clause-Patent > > ; > > ;**/ > > @@ -26,20 +26,6 @@ > > > %define FXSTOR_FLAG 0x1000000 ; bit cpuid 24 of feature flags > > > > -;; The FXSTOR and FXRSTOR commands are used for saving and restoring the > x87, > > -;; MMX, SSE, SSE2, etc registers. The initialization of the debugsupport > driver > > -;; MUST check the CPUID feature flags to see that these instructions are > available > > -;; and fail to init if they are not. > > - > > -;; fxstor [edi] > > -%macro FXSTOR_EDI 0 > > - db 0xf, 0xae, 00000111y ; mod = 00, reg/op = > 000, r/m = 111 = [edi] > > -%endmacro > > - > > -;; fxrstor [esi] > > -%macro FXRSTOR_ESI 0 > > - db 0xf, 0xae, 00001110y ; mod = 00, reg/op = > 001, r/m = 110 = [esi] > > -%endmacro > > SECTION .data > > > > global ASM_PFX(OrigVector) > > @@ -348,7 +334,7 @@ ExtraPushDone: > ; IMPORTANT!! The debug stack has been carefully > constructed to > > ; insure that esp and edi are 16 byte aligned when we > get here. > > ; They MUST be. If they are not, a GP fault will occur. > > - FXSTOR_EDI > > + fxsave [edi] > > > > ;; UEFI calling convention for IA32 requires that Direction flag in EFLAGs is > clear > > cld > > @@ -372,7 +358,7 @@ ExtraPushDone: > > > ;; FX_SAVE_STATE_IA32 FxSaveState; > > mov esi, esp > > - FXRSTOR_ESI > > + fxrstor [esi] > > add esp, 512 > > > > ;; UINT32 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7; > > diff --git a/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm > b/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm > index 9cc38a3128..c6c5e49189 100644 > --- a/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm > +++ b/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm > @@ -1,7 +1,7 @@ > ;/** @file > > ; Low level x64 routines used by the debug support driver. > > ; > > -; Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR> > > +; Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.<BR> > > ; SPDX-License-Identifier: BSD-2-Clause-Patent > > ; > > ;**/ > > @@ -26,21 +26,6 @@ > > > %define FXSTOR_FLAG 0x1000000 ; bit cpuid 24 of feature flags > > > > -;; The FXSTOR and FXRSTOR commands are used for saving and restoring the > x87, > > -;; MMX, SSE, SSE2, etc registers. The initialization of the debugsupport > driver > > -;; MUST check the CPUID feature flags to see that these instructions are > available > > -;; and fail to init if they are not. > > - > > -;; fxstor [rdi] > > -%macro FXSTOR_RDI 0 > > - db 0xf, 0xae, 00000111y ; mod = 00, reg/op = > 000, r/m = 111 = [rdi] > > -%endmacro > > - > > -;; fxrstor [rsi] > > -%macro FXRSTOR_RSI 0 > > - db 0xf, 0xae, 00001110y ; mod = 00, reg/op = > 001, r/m = 110 = [rsi] > > -%endmacro > > - > > SECTION .data > > > > global ASM_PFX(OrigVector) > > @@ -381,7 +366,7 @@ ExtraPushDone: > ; IMPORTANT!! The debug stack has been carefully > constructed to > > ; insure that rsp and rdi are 16 byte aligned when we get > here. > > ; They MUST be. If they are not, a GP fault will occur. > > - FXSTOR_RDI > > + fxsave [rdi] > > > > ;; UEFI calling convention for x64 requires that Direction flag in EFLAGs is > clear > > cld > > @@ -404,7 +389,7 @@ ExtraPushDone: > > > ;; FX_SAVE_STATE_X64 FxSaveState; > > mov rsi, rsp > > - FXRSTOR_RSI > > + fxrstor [rsi] > > add rsp, 512 > > > > ;; UINT64 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7; > > -- > 2.28.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86551): https://edk2.groups.io/g/devel/message/86551 Mute This Topic: https://groups.io/mt/89041503/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
