This patch looks good to me. Reviewed-by: Yuwei Chen<yuwei.c...@intel.com>
> -----Original Message----- > From: Lou, Yun <yun....@intel.com> > Sent: Monday, January 10, 2022 11:13 PM > To: devel@edk2.groups.io > Cc: Lou, Yun <yun....@intel.com>; Feng, Bob C <bob.c.f...@intel.com>; > Gao, Liming <gaolim...@byosoft.com.cn>; Chen, Christine > <yuwei.c...@intel.com> > Subject: [PATCH v2 6/6] BaseTools: Upgrade the version of NASM tool > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 > > Upgrade the version of NASM tool to avoid compilation errors when > compiling NASM code change. > > Signed-off-by: Jason Lou <yun....@intel.com> > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Yuwei Chen <yuwei.c...@intel.com> > --- > BaseTools/Conf/tools_def.template | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 2e6b382ab6..0133860fc3 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1,5 +1,5 @@ > #-# Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>+# > Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR> # > Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> # > Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.<BR> # > Copyright (c) 2015, Hewlett-Packard Development Company, L.P.<BR>@@ - > 368,8 +368,8 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc > # Other Supported Tools # ===================== # NASM -- > http://www.nasm.us/-# - NASM 2.10 or later for use with the GCC toolchain > family-# - NASM 2.12.01 or later for use with all other toolchain families+# > - NASM 2.15.05 or later for use with the GCC toolchain family+# - NASM > 2.15.05 or later for use with all other toolchain families # > ################################################################ > #################### > ################################################################ > ####################-- > 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85721): https://edk2.groups.io/g/devel/message/85721 Mute This Topic: https://groups.io/mt/88325173/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
