Hi Cheng-chieh, The Github comments is just for your reference to quick locate the comment place. You could update the PR with new changes and I could comment there. But we still need follow EDII requirement to review the patches by email.
Thanks, Guo From: Cheng-Chieh Huang <chengch...@google.com> Sent: Saturday, August 7, 2021 8:06 AM To: devel@edk2.groups.io Cc: Schaefer, Daniel <daniel.schae...@hpe.com>; Trammell Hudson <hud...@trmm.net>; Ma, Maurice <maurice...@intel.com>; Dong, Guo <guo.d...@intel.com>; You, Benjamin <benjamin....@intel.com> Subject: Re: [PATCH v2 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload Hi Guo, I saw you left messages in https://github.com/tianocore/edk2/pull/1820. If it's also possible to upstreaming using github PR. I can just update my old branch. -- Cheng-chieh On Sat, Aug 7, 2021 at 10:51 PM Cheng-Chieh Huang <chengch...@google.com<mailto:chengch...@google.com>> wrote: These are necessary patches to Support LinuxBoot in UefiPayload. With these paches, we can boot to ESXi and Windows from a linux in QEMU. This is second parse. In addition to fixing reviwer's suggestions, I removed the following CLs. * Add DISABLE_MMX_SSE to avoid generating floating points operation -> will send a seperate patch to add these flags to BaseTools * LinuxBoot: use a text format for the configuration block. -> will work with Trammell Hudson to cover this patch to EDK2 style. LinuxBoot README: https://github.com/linuxboot/edk2/blob/uefipayload/UefiPayloadPkg/README.md v2 PR to tianocore: https://github.com/tianocore/edk2/pull/1873 Cheng-Chieh Huang (4): UefiPayloadPkg: Add LINUXBOOT payload target UefiPayloadPkg: Use legacy timer in Linuxboot payload UefiPayloadPkg: Update maximum logic processor to 256 UefiPayloadPkg: Reserve Payload config in runtime services data UefiPayloadPkg/UefiPayloadPkg.dsc | 24 ++- UefiPayloadPkg/UefiPayloadPkg.fdf | 5 + UefiPayloadPkg/Library/LbParseLib/LbParseLib.inf | 39 +++++ UefiPayloadPkg/Library/LbParseLib/Linuxboot.h | 47 +++++ UefiPayloadPkg/Library/LbParseLib/LbParseLib.c | 182 ++++++++++++++++++++ UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 6 +- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 4 + 7 files changed, 299 insertions(+), 8 deletions(-) create mode 100644 UefiPayloadPkg/Library/LbParseLib/LbParseLib.inf create mode 100644 UefiPayloadPkg/Library/LbParseLib/Linuxboot.h create mode 100644 UefiPayloadPkg/Library/LbParseLib/LbParseLib.c Cc: Cheng-Chieh Huang <chengch...@google.com<mailto:chengch...@google.com>> Cc: Daniel Schaefer <daniel.schae...@hpe.com<mailto:daniel.schae...@hpe.com>> Cc: Trammell Hudson <hud...@trmm.net<mailto:hud...@trmm.net>> Cc: Maurice Ma <maurice...@intel.com<mailto:maurice...@intel.com>> Cc: Guo Dong <guo.d...@intel.com<mailto:guo.d...@intel.com>> Cc: Benjamin You <benjamin....@intel.com<mailto:benjamin....@intel.com>> -- 2.32.0.605.g8dce9f2422-goog -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78853): https://edk2.groups.io/g/devel/message/78853 Mute This Topic: https://groups.io/mt/84731094/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
