On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The "OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf" > instance is used in the following platforms in edk2: > > OvmfPkg/Bhyve/BhyveX64.dsc > OvmfPkg/OvmfXen.dsc > > Neither Bhyve nor Xen provide a Q35 board, therefore the expression > > PcdGet16 (PcdOvmfHostBridgePciDevId) != INTEL_Q35_MCH_DEVICE_ID > > always evaluates to TRUE, in the PciHostBridgeLibScan instance. > > Replace the expression with constant TRUE, eliminating the PCD dependency. > > (In effect, this reports that the root bridge being registered does not > support extended PCI config space.) > > Cc: Anthony Perard <anthony.per...@citrix.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Julien Grall <jul...@xen.org> > Cc: Peter Grehan <gre...@freebsd.org> > Cc: Philippe Mathieu-Daudé <phi...@redhat.com> > Cc: Rebecca Cran <rebe...@bsdio.com> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf | 4 ---- > OvmfPkg/Library/PciHostBridgeLibScan/XenSupport.c | 4 +--- > 2 files changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75774): https://edk2.groups.io/g/devel/message/75774 Mute This Topic: https://groups.io/mt/83111024/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
