On 5/26/21 10:14 PM, Laszlo Ersek wrote: > According to the function-top comment, SmbiosTablePublishEntry() is > supposed to return an error code if no SMBIOS data is found, from either > GetXenSmbiosTables() or GetQemuSmbiosTables(). Currently the function > returns EFI_SUCCESS in this case however (propagated from > gBS->LocateProtocol()). Make the return code match the documentation. > > (This issue is not too important, but it gets in the way of splitting the > entry point function next.) > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Philippe Mathieu-Daudé <phi...@redhat.com> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 1 + > 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75785): https://edk2.groups.io/g/devel/message/75785 Mute This Topic: https://groups.io/mt/83111115/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
