Thanks. Comments below: > -----Original Message----- > From: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com> > Sent: Thursday, November 7, 2019 4:00 AM > To: Yao, Jiewen <jiewen....@intel.com>; devel@edk2.groups.io > Cc: Ni, Ray <ray...@intel.com>; Lou, Yun <yun....@intel.com> > Subject: RE: [PATCH V2 1/6] IntelSiliconPkg/Include: Add Intel PciSecurity > definition. > > Hi Jiewen, > Few comments: > 1. Can we put a reference to the spec at the file header? [Jiewen] Agree. Will add in V3.
> 2. Can we group all the macros at the top followed by structure definitions? [Jiewen] I believe we had better to keep macro close to the data structure definition. Take UefiSpec.h as example. EFI_MEMORY_xxx is close to EFI_MEMORY_DESCRIPTOR EVT_xxx is close to EFI_EVENT_NOTIFY TPL_xxx is close to EFI_RAISE_TPL Same example in Acpi.h We put definition close to the structure, instead of put all definition together on the top. > 3. Is it possible to add some high level description above the structure > definition > that describes the structure? [Jiewen] Agree. Will add in V3. > 4. I see line 80 is commented out. Can we remove that line? [Jiewen] This is a typical way to define a variable length field. You may find similar examples in EDKII. Just search []; C:\home\edkii\edk2\MdePkg\Include\Guid\CapsuleReport.h(84): /// CHAR16 CapsuleFileName[]; C:\home\edkii\edk2\MdePkg\Include\Guid\CapsuleReport.h(92): /// CHAR16 CapsuleTarget[]; C:\home\edkii\edk2\MdePkg\Include\Guid\FmpCapsule.h(46): // UINT64 ItemOffsetList[]; C:\home\edkii\edk2\MdePkg\Include\Guid\ImageAuthentication.h(300): /// CHAR16 Name[]; C:\home\edkii\edk2\MdePkg\Include\Guid\StatusCodeDataTypeId.h(230): // UINT8 ReqRes[]; C:\home\edkii\edk2\MdePkg\Include\Guid\StatusCodeDataTypeId.h(235): // UINT8 AllocRes[]; C:\home\edkii\edk2\MdePkg\Include\Guid\SystemResourceTable.h(114): //EFI_SYSTEM_RESOURCE_ENTRY Entries[]; C:\home\edkii\edk2\MdePkg\Include\Guid\WinCertificate.h(116): /// UINT8 Signature[]; > 5. Please add some description about the change after line 5. [Jiewen] Line 5 ? It is about license. Would you please clarify what description is required there? > > Thanks, > Sai > > -----Original Message----- > From: Yao, Jiewen > Sent: Thursday, October 31, 2019 5:31 AM > To: devel@edk2.groups.io > Cc: Ni, Ray <ray...@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com>; Lou, Yun <yun....@intel.com> > Subject: [PATCH V2 1/6] IntelSiliconPkg/Include: Add Intel PciSecurity > definition. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303 > > Cc: Ray Ni <ray...@intel.com> > Cc: Rangasai V Chaganty <rangasai.v.chaga...@intel.com> > Cc: Yun Lou <yun....@intel.com> > Signed-off-by: Jiewen Yao <jiewen....@intel.com> > --- > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IntelPciSecurity.h | > 66 > ++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IntelPciSecurity.h > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IntelPciSecurity.h > new file mode 100644 > index 0000000000..a8c5483165 > --- /dev/null > +++ > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IntelPciSecurity.h > @@ -0,0 +1,66 @@ > +/** @file > + Intel PCI security data structure > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> > +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef __INTEL_PCI_SECURITY_H__ > +#define __INTEL_PCI_SECURITY_H__ > + > +#pragma pack(1) > + > +typedef struct { > + UINT16 CapId; // 0x23: DVSEC > + UINT16 CapVersion:4; // 1 > + UINT16 NextOffset:12; > + UINT16 DvSecVendorId; // 0x8086 > + UINT16 DvSecRevision:4; // 1 > + UINT16 DvSecLength:12; > + UINT16 DvSecId; // 0x3E: Measure > +} INTEL_PCI_DIGEST_CAPABILITY_HEADER; > + > +#define INTEL_PCI_CAPID_DVSEC 0x23 > +#define INTEL_PCI_DVSEC_VENDORID_INTEL 0x8086 > +#define INTEL_PCI_DVSEC_DVSECID_MEASUREMENT 0x3E > + > +typedef union { > + struct { > + UINT8 DigestModified:1; // RW1C > + UINT8 Reserved0:7; > + } Bits; > + UINT8 Data; > +} INTEL_PCI_DIGEST_DATA_MODIFIED; > + > +#define INTEL_PCI_DIGEST_MODIFIED BIT0 > + > +typedef union { > + struct { > + UINT8 Digest0Valid:1; // RO > + UINT8 Digest0Locked:1; // RO > + UINT8 Digest1Valid:1; // RO > + UINT8 Digest1Locked:1; // RO > + UINT8 Reserved1:4; > + } Bits; > + UINT8 Data; > +} INTEL_PCI_DIGEST_DATA_VALID; > + > +#define INTEL_PCI_DIGEST_0_VALID BIT0 > +#define INTEL_PCI_DIGEST_0_LOCKED BIT1 > +#define INTEL_PCI_DIGEST_1_VALID BIT2 > +#define INTEL_PCI_DIGEST_1_LOCKED BIT3 > + > +typedef struct { > + INTEL_PCI_DIGEST_DATA_MODIFIED Modified; // RW1C > + INTEL_PCI_DIGEST_DATA_VALID Valid; // RO > + UINT16 TcgAlgId; // RO > + UINT8 FirmwareID; // RO > + UINT8 Reserved; > +//UINT8 Digest[]; > +} INTEL_PCI_DIGEST_CAPABILITY_STRUCTURE; > + > +#pragma pack() > + > +#endif > + > -- > 2.19.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50158): https://edk2.groups.io/g/devel/message/50158 Mute This Topic: https://groups.io/mt/40117796/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
