Hi Phil,
To make python script to be executable, I think only change file permission
would not be enough. There also need to be a shebang
#!/usr/bin/env python at the top of this script.
But from the patch 3/3, I see in the GitCcCmd.sh, GetMaintainer.py is called by
"python ${EDK_TOOLS_PATH}/Scripts/GetMaintainer.py --quiet"
Python interpreter is called explicit, so I think it's not necessary to change
GetMaintainer.py permission.
Thanks,
Bob
-----Original Message-----
From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
Sent: Wednesday, October 16, 2019 10:10 PM
To: Leif Lindholm <leif.lindh...@linaro.org>; devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <liming....@intel.com>;
Laszlo Ersek <ler...@redhat.com>; Philippe Mathieu-Daude <phi...@redhat.com>
Subject: [PATCH 1/3] BaseTools: Let the GetMaintainer.py script be executable
The GetMaintainer.py script use the "if __name__ == '__main__'"
evaluation so it expects to be run as a standalone program.
We have other Python scripts with the executable permission, let this one be
executable too.
Signed-off-by: Philippe Mathieu-Daude <phi...@redhat.com>
---
BaseTools/Scripts/GetMaintainer.py | 0
1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755
BaseTools/Scripts/GetMaintainer.py
diff --git a/BaseTools/Scripts/GetMaintainer.py
b/BaseTools/Scripts/GetMaintainer.py
old mode 100644
new mode 100755
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49211): https://edk2.groups.io/g/devel/message/49211
Mute This Topic: https://groups.io/mt/34560654/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
