Hi Phil, On 10/16/19 16:09, Philippe Mathieu-Daude wrote: > Hi, > > This series contains trivial fixes to the GetMaintainer.py script, > then adds a new script which allow git-send-email to automatically > fills the email addresses relevant to each patch, using the new > Maintainer.txt format (with the GetMaintainer.py script). > > I sent this series adding: > > [sendemail] > ccCmd = /home/phil/source/edk2/BaseTools/Scripts/GitCcCmd.sh > > To my /home/phil/source/edk2/.git/config > > The sendemail.ccCmd entry is documented here: > https://git-scm.com/docs/git-send-email#Documentation/git-send-email.txt---cc-cmdltcommandgt
I'm neutral on this patch set; I defer to Leif and others for reviewing it. I like to rely on explicit Cc: tags in the commit messages, and those tags only. They give me better per-patch control, they work nicely across rebases, and I like to see them in the git commit history too. Furthermore, if someone else takes over a patch from a pending series, for a rework, they get the Cc's too. If a reviewer expresses permanent uninterest in a patch, I can drop them permanently. That said, I don't mind if others use "sendemail.ccCmd"! Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49110): https://edk2.groups.io/g/devel/message/49110 Mute This Topic: https://groups.io/mt/34560653/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
