On 10/16/19 5:18 PM, Leif Lindholm wrote:
Hi Phil,
This is definitely a manual step that could do with automation, so
many thanks for having a go. ...But, I have a few reservations
regarding the actual solution.
First of all, doing it as a .sh means it will not work for those
developers working primarily with Visual Studio. Rewriting it as
python script would resolve this, and also let you import
GetMaintainer.py and use functions from there instead of adding a
quiet mode to that. (I would very much like to not turn the
GetMaintainer.py output into an ABI.)
OK. I was not expecting the .sh to get merged but wanted to have
feedback as in a RFC, so I sent it mostly as a proof of concept.
Secondly, I agree with Laszlo that I would rather see something that
operated with format-patch than send-email (since we want to keep the
Cc: tags in the commit messages). That command does not have the same
useful hook, however.
Laszlo's reply and yours are the feedback I was expecting :)
For this reason *I* would not use said script, but I'm not going to
say we shouldn't have it. I will say it shouldn't be enabled by
default by SetupGit.py though.
Well, I wrote it because I use git-publish in my workflow and wanted to
use your GetMaintainer script output to select the recipients.
I'm not custom to the Cc tag (I don't use it). Maybe my problem is
git-publish not handling correctly the Cc tag feature, so forget about
this series for now, I'll see how to better integrate both tools in my
workflow and eventually respin (without using your script as a stable ABI).
Regards,
Phil.
On Wed, Oct 16, 2019 at 04:09:37PM +0200, Philippe Mathieu-Daude wrote:
This series contains trivial fixes to the GetMaintainer.py script,
then adds a new script which allow git-send-email to automatically
fills the email addresses relevant to each patch, using the new
Maintainer.txt format (with the GetMaintainer.py script).
I sent this series adding:
[sendemail]
ccCmd = /home/phil/source/edk2/BaseTools/Scripts/GitCcCmd.sh
To my /home/phil/source/edk2/.git/config
The sendemail.ccCmd entry is documented here:
https://git-scm.com/docs/git-send-email#Documentation/git-send-email.txt---cc-cmdltcommandgt
Regards,
Phil.
Philippe Mathieu-Daudé (3):
BaseTools: Let the GetMaintainer.py script be executable
BaseTools: Add '--quiet' option to GetMaintainer.py script
BaseTools: Add script to help git-send-email pick addresses to cc
BaseTools/Scripts/GetMaintainer.py | 9 +++++--
BaseTools/Scripts/GitCcCmd.sh | 38 ++++++++++++++++++++++++++++++
2 files changed, 45 insertions(+), 2 deletions(-)
mode change 100644 => 100755 BaseTools/Scripts/GetMaintainer.py
create mode 100755 BaseTools/Scripts/GitCcCmd.sh
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49116): https://edk2.groups.io/g/devel/message/49116
Mute This Topic: https://groups.io/mt/34560653/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
