Reviewed-by: Siyuan Fu <siyuan...@intel.com> > -----Original Message----- > From: Philippe Mathieu-Daudé <phi...@redhat.com> > Sent: 2019年9月24日 0:04 > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Wu, Jiaxin <jiaxin...@intel.com>; Fu, Siyuan <siyuan...@intel.com> > Subject: Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix > NetLibDestroyServiceChild() call > > On 9/17/19 9:49 PM, Laszlo Ersek wrote: > > Both NetLibDestroyServiceChild() and > EFI_SERVICE_BINDING_DESTROY_CHILD > > take an EFI_HANDLE for the "ChildHandle" parameter, not an > (EFI_HANDLE*). > > > > This patch fixes a real bug. > > > > Cc: Jiaxin Wu <jiaxin...@intel.com> > > Cc: Siyuan Fu <siyuan...@intel.com> > > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > > --- > > > > Notes: > > possibly only build-tested > > > > NetworkPkg/Ip4Dxe/Ip4If.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/NetworkPkg/Ip4Dxe/Ip4If.c b/NetworkPkg/Ip4Dxe/Ip4If.c > > index 44b8d9fc8faf..53a333037f94 100644 > > --- a/NetworkPkg/Ip4Dxe/Ip4If.c > > +++ b/NetworkPkg/Ip4Dxe/Ip4If.c > > @@ -592,7 +592,7 @@ Ip4SetAddress ( > > Interface->Controller, > > Interface->Image, > > &gEfiArpServiceBindingProtocolGuid, > > - &Interface->ArpHandle > > + Interface->ArpHandle > > ); > > > > Interface->ArpHandle = NULL; > > @@ -657,7 +657,7 @@ ON_ERROR: > > Interface->Controller, > > Interface->Image, > > &gEfiArpServiceBindingProtocolGuid, > > - &Interface->ArpHandle > > + Interface->ArpHandle > > I'm surprise this one never triggered unexpected behaviors, it > looks easy to reach. > > Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> > > > ); > > > > return Status; > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48153): https://edk2.groups.io/g/devel/message/48153 Mute This Topic: https://groups.io/mt/34180221/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
