Reviewed-by: Dandan Bi <dandan...@intel.com> Thanks, Dandan
> -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, September 18, 2019 3:49 AM > To: edk2-devel-groups-io <devel@edk2.groups.io> > Cc: Bi, Dandan <dandan...@intel.com>; Dong, Eric <eric.d...@intel.com>; > Wu, Hao A <hao.a...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Ni, > Ray <ray...@intel.com>; Gao, Zhichao <zhichao....@intel.com> > Subject: [PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE for > keystroke notify registration > > EFI_REGISTER_KEYSTROKE_NOTIFY and > EFI_UNREGISTER_KEYSTROKE_NOTIFY require the notification handle to > have type (VOID*). The notification handle has nothing to do with the > EFI_HANDLE type. > > This change is a semantic fix; functionally, it's a no-op. > > Cc: Dandan Bi <dandan...@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Zhichao Gao <zhichao....@intel.com> > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > > Notes: > lightly tested: ConSplitterDxe is part of the ArmVirt and OVMF platforms > > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- > MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > index 63c814ae1816..9c38271b65f9 100644 > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > @@ -4026,7 +4026,7 @@ ConSplitterTextInRegisterKeyNotify ( > if (NewNotify == NULL) { > return EFI_OUT_OF_RESOURCES; > } > - NewNotify->NotifyHandleList = (EFI_HANDLE *) AllocateZeroPool (sizeof > (EFI_HANDLE) * Private->TextInExListCount); > + NewNotify->NotifyHandleList = (VOID **) AllocateZeroPool (sizeof > + (VOID *) * Private->TextInExListCount); > if (NewNotify->NotifyHandleList == NULL) { > gBS->FreePool (NewNotify); > return EFI_OUT_OF_RESOURCES; > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > index 7cfd5c178861..f98797225b63 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > +++ b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > @@ -143,7 +143,7 @@ InternalStartMonitor( > EFI_HANDLE *Handles; > UINTN HandleCount; > UINTN HandleIndex; > - EFI_HANDLE NotifyHandle; > + VOID *NotifyHandle; > > Status = gBS->LocateHandleBuffer ( > ByProtocol, > @@ -202,7 +202,7 @@ InternalStopMonitor( > EFI_KEY_DATA KeyData; > UINTN HandleCount; > UINTN HandleIndex; > - EFI_HANDLE NotifyHandle; > + VOID *NotifyHandle; > > Status = gBS->LocateHandleBuffer ( > ByProtocol, > -- > 2.19.1.3.g30247aa5d201 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47518): https://edk2.groups.io/g/devel/message/47518 Mute This Topic: https://groups.io/mt/34180213/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
