On 07/16/19 04:27, Rebecca Cran wrote: > On 2019-07-15 20:16, Laszlo Ersek wrote: >> That said, if you wouldn't like to rework the patch, I can give my R-b >> as-is (please confirm). > > > Thanks, I like your suggested changes. And I just ran shellcheck and was > told "SC2230: which is non-standard. Use builtin 'command -v' instead.".
Great, and thank you for teaching me about "shellcheck". (I generally use the POSIX spec, and "dash", when I try to write portable shell scripts.) Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43782): https://edk2.groups.io/g/devel/message/43782 Mute This Topic: https://groups.io/mt/32483827/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
