On 07/16/19 04:20, Rebecca Cran wrote: > On 2019-07-15 19:53, Laszlo Ersek wrote: >> >> But, I think the question stands; there's more that could be quoted. >> What is the reason for quoting just these? > > > Mainly because I thought those were the ones that were most important to > add quotes around. I'll probably submit a follow-up patch to fix the > others and further reduce the number of shellcheck warnings. > >
Sounds good. This would be very good to capture in the commit message. Can you please submit a new full version of the set, with the commit messages updated? For this patch, with the additional reasoning included: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43780): https://edk2.groups.io/g/devel/message/43780 Mute This Topic: https://groups.io/mt/32483828/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
