On 07/16/19 12:32, Laszlo Ersek wrote: > On 07/16/19 04:13, Rebecca Cran wrote: >> On 2019-07-15 19:37, Laszlo Ersek wrote: >>> >>> (Sorry if the reason was already given and I missed it:) >>> >>> Why is this an improvement? >>> >>> The docs at <https://man.openbsd.org/pwd.1> say: >>> >>> "pwd also exists as a built-in to ksh(1), which may have a different >>> default behavior". Is that the reason? >> >> No, it's mainly as a (very minor) optimization: `pwd` runs the command >> (even as a built-in), whereas $PWD simply evaluates the value of the >> variable. >> >> Also, modern scripts as I understand it should generally use $(...) to >> run commands, instead of `...`. >> >> > > Makes sense, thanks. > > For this patch: > > Reviewed-by: Laszlo Ersek <ler...@redhat.com>
... As I requested a minute ago, my preference would be to see a v3 of the full series on the list -- if you agree, please include the "micro-optimization" language from your reply above in the commit message of this patch, together with my R-b. Thank you! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43781): https://edk2.groups.io/g/devel/message/43781 Mute This Topic: https://groups.io/mt/32483820/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
