zjffdu commented on a change in pull request #3271: [ZEPPELIN-3919] Paragraph
config default value can be customized
URL: https://github.com/apache/zeppelin/pull/3271#discussion_r243931887
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java
##########
@@ -365,6 +369,13 @@ public void fireParagraphUpdateEvent(Paragraph p) throws
IOException {
*/
public Paragraph insertNewParagraph(int index, AuthenticationInfo
authenticationInfo) {
Paragraph paragraph = new Paragraph(this, paragraphJobListener);
+ if (null != interpreterSettingManager) {
+ // Set the default parameter configuration for the paragraph
+ // based on `interpreter-setting.json` config
+ Map<String, Object> config =
+ interpreterSettingManager.getConfigSetting(defaultInterpreterGroup);
+ paragraph.setConfig(config);
+ }
Review comment:
I understand this. But as I said before, the default interpreter of new
paragraph may not be the default interpreter of note. e.g. You can may get the
config of `submarine` but the magics part could be `%python`. So I would
suggest we first change the behavior of how to set the default interpreter of
new paragraph. This is currently what zeppelin to do.
https://github.com/apache/zeppelin/pull/3271/files#diff-0f40daff726ba29c9a004b342d422dfeR380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
