zjffdu commented on a change in pull request #3271: [ZEPPELIN-3919] Paragraph
config default value can be customized
URL: https://github.com/apache/zeppelin/pull/3271#discussion_r243930299
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java
##########
@@ -569,6 +593,45 @@ public void setConfig(Map<String, Object> config) {
this.config = config;
}
+ // apply the `interpreter-setting.json` config
+ // When creating a paragraph, it will update some of the configuration
+ // parameters of the paragraph from the web side.
+ // Need to deal with 2 situations
+ // 1. The interpreter does not have a config configuration set,
+ // so newConfig is equal to null, Need to be processed using the
+ // default parameters of the interpreter
+ // 2. The user manually modified the interpreter types of this paragraph.
+ // Need to delete the existing configuration of this paragraph,
+ // update with the specified interpreter configuration
+ public void applyConfigSetting(Map<String, Object> newConfig) {
Review comment:
Can we add unit test for this ? Since this is not trivial
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
