zjffdu commented on a change in pull request #3271: [ZEPPELIN-3919] Paragraph 
config default value can be customized
URL: https://github.com/apache/zeppelin/pull/3271#discussion_r243929373
 
 

 ##########
 File path: docs/development/writing_zeppelin_interpreter.md
 ##########
 @@ -118,6 +118,12 @@ Here is an example of `interpreter-setting.json` on your 
own interpreter.
       "language": "your-syntax-highlight-language",
       "editOnDblClick": false,
       "completionKey": "TAB"
+    },
+    "config": {
+      "fontSize": 9,
+      "colWidth": 12,
 
 Review comment:
   Do we need to expose `fontSize` and `colWidth` to user to customize ? I 
don't see you need it here. If not, we could remove them, and expose them later 
in future if it is really necessary.  Because once we expose something to 
users, we have to maintain it and keep compatibility. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to