Copilot commented on code in PR #3094:
URL: https://github.com/apache/tika/pull/3094#discussion_r3887418713
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-apple-module/src/main/java/org/apache/tika/parser/iwork/iwana/IWork18PackageParser.java:
##########
@@ -71,28 +77,68 @@ public void parse(TikaInputStream tis, ContentHandler
handler, Metadata metadata
zipStream = new ZipInputStream(tis);
}
- // For now, just detect
+ // Detect the type, and emit the document preview as the thumbnail;
+ // the content itself is not parsed yet
+ XHTMLContentHandler xhtml = new XHTMLContentHandler(handler, metadata,
context);
+ xhtml.startDocument();
Review Comment:
When `tis.hasFile()` is true and the parser opens a new
`org.apache.commons.compress.archivers.zip.ZipFile` via
`ZipFile.builder().setFile(...)`, that `ZipFile` is never closed or registered
with `TikaInputStream` for cleanup. This can leak file descriptors (especially
on exceptions) during parsing. Consider registering the newly opened ZipFile
with `TikaInputStream` (similar to `DefaultZipContainerDetector`) so it will be
closed when the stream is closed, without interfering with a pre-existing
openContainer ZipFile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
