dschmidt commented on code in PR #3094: URL: https://github.com/apache/tika/pull/3094#discussion_r3886882321
########## tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-apple-module/src/test/java/org/apache/tika/parser/iwork/iwana/IWork18ParserTest.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.tika.parser.iwork.iwana; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +import java.io.ByteArrayOutputStream; +import java.io.InputStream; +import java.util.List; +import java.util.zip.ZipEntry; +import java.util.zip.ZipInputStream; +import java.util.zip.ZipOutputStream; + +import org.junit.jupiter.api.Test; + +import org.apache.tika.TikaTest; +import org.apache.tika.io.TikaInputStream; +import org.apache.tika.metadata.HttpHeaders; +import org.apache.tika.metadata.Metadata; +import org.apache.tika.metadata.TikaCoreProperties; +import org.apache.tika.parser.ParseContext; + +public class IWork18ParserTest extends TikaTest { + + /** + * The package's preview.jpg is the document's THUMBNAIL embedded + * document. The test fixture was saved without one, so a preview is + * added to a copy of it. + */ + @Test + public void testPreviewIsTheThumbnail() throws Exception { + ByteArrayOutputStream bos = new ByteArrayOutputStream(); + try (InputStream is = getResourceAsStream("/test-documents/testKeynote2018.key"); + ZipInputStream in = new ZipInputStream(is); + ZipOutputStream out = new ZipOutputStream(bos)) { + ZipEntry entry; + while ((entry = in.getNextEntry()) != null) { + out.putNextEntry(new ZipEntry(entry.getName())); + in.transferTo(out); + out.closeEntry(); + } + out.putNextEntry(new ZipEntry("Presentation.key/preview.jpg")); + out.write(new byte[]{(byte) 0xFF, (byte) 0xD8, (byte) 0xFF, (byte) 0xD9}); + out.closeEntry(); Review Comment: Fixed: the test now writes a small well-formed JPEG produced by ImageIO. ########## tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-apple-module/src/main/java/org/apache/tika/parser/iwork/IWorkPackageParser.java: ########## @@ -104,7 +130,7 @@ public void parse(TikaInputStream tis, ContentHandler handler, Metadata metadata entryStream.reset(); // 4096 fails on github if (type != null) { - XHTMLContentHandler xhtml = new XHTMLContentHandler(handler, metadata, context); + xhtml = new XHTMLContentHandler(handler, metadata, context); ContentHandler contentHandler; switch (type) { Review Comment: Fixed: the handler is created and the document started once, on the first content entry; endDocument stays after the loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
