On Sun, Jul 13, 2014 at 2:29 AM, Dimitris Zervas <dzer...@dzervas.gr> wrote: > I think that the patch is ready. > It has some little bugs and some beautiful vim keys were not implemented > (such as r), but I'll work on them... > I'm not into creating a dozen more functions, so it will take me some time to > think a way to implement them...
Great work! I found a couple of bugs, but they should be easy to fix. There is room for some more code, but I appreciate you keeping things simple. I think we could aim for maximum expectability while keeping the amount of code at a minimum: anyone using basic vi commands should feel mostly at home when using sandy. As a personal opinion, I'd rather not implement complex text operations that can be "piped out" (e.g. :s/foo/bar/, upper/lower case...) but other than that feel free to code away. > So, here you go! :) > You can also get the latest commit from my repo (https://git.dzervas.gr, it > won't crash :P) I have applied this after changing t_nocomm()'s name to t_ins(). I've also added your name to the LICENSE file. However, I tried pushing to git.suckless.org, but I can no longer login to my account (r...@suckless.org) with my SSH key. Sigh. I have pushed it to my personal fork at https://bitbucket.org/rafaelgg/sandy > I've not touched the data structures, and I won't, until I reach sandy's > features up to a point that it can be my main editor. Thanks for that. Let's try to make a decent simple vi-like editor and then start worrying about performance and whatnot. Cheers, Rafa