dsahlberg-apache-org commented on code in PR #32:
URL: https://github.com/apache/subversion/pull/32#discussion_r2208460802
##########
build/ac-macros/serf.m4:
##########
@@ -89,6 +89,13 @@ AC_DEFUN(SVN_LIB_SERF,
svn_lib_serf=$serf_found
+ if test "$svn_lib_serf" = "yes"; then
+ save_ldflags="$LDFLAGS"
+ LDFLAGS="$LDFLAGS $SVN_SERF_LIBS"
+ AC_CHECK_FUNCS(serf_ssl_error_cb_set)
+ LDFLAGS="$save_ldflags"
+ fi
+
Review Comment:
Reminder to self: Do we need to implement something similar for CMake ?
##########
subversion/libsvn_ra_serf/util.c:
##########
@@ -567,7 +584,14 @@ conn_setup(apr_socket_t *sock,
SERF_CONNECTION_FRAMING_TYPE_NONE);
}
#endif
- }
+
+#if defined(HAVE_SERF_SSL_ERROR_CB_SET)
+ serf_ssl_error_cb_set(conn->ssl_context,
+ ssl_error_cb,
+ conn);
+#endif
+
+ }
Review Comment:
Formatting-nerd: Is there a tab vs space issue hiding here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@subversion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
