brainy commented on code in PR #32:
URL: https://github.com/apache/subversion/pull/32#discussion_r2177579268
##########
subversion/libsvn_ra_serf/util.c:
##########
@@ -451,6 +451,20 @@ ssl_server_cert_cb(void *baton, int failures,
return save_error(session, err);
}
+#if defined(HAVE_SERF_SSL_ERROR_CB_SET)
+static apr_status_t
+ssl_error_cb(void *baton,
+ const char *message)
+{
+ svn_ra_serf__connection_t *conn = baton;
+ svn_ra_serf__session_t *session = conn->session;
+
+ session->ssl_error = apr_pstrdup(session->pool, message);
Review Comment:
Sorry, never mind, of course it can.
The right thing to do here would be to make `session->ssl_error` an
`svn_error_t`, then just chain those errors together as they arrive, and wrap
the chain when reporting the error. Could even drop the `if` there because
wrapping a null `svn_error_t` is just fine. The nice thing about chaining
errors is that the whole chain uses just the one (standalone) pool that's
created for the first error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
