Nathan Hartman wrote on Wed, 20 Nov 2024 21:21 +00:00:
> On Wed, Nov 20, 2024 at 12:16 PM Daniel Sahlberg <
> daniel.l.sahlb...@gmail.com> wrote:
>> Den ons 20 nov. 2024 kl 14:50 skrev Daniel Shahaf <d...@daniel.shahaf.name
>>> B. Would more maintainers use the interactive functions if they [the
>>> interactive functions] were implemented in Python?
>>>
>>
>> No, not because of the language, but maybe if it was more widely know they
>> exist. I've used them a little and they are very nice. Using the scripts to
>> nominate would have prevented the backport failure we recently had, where
>> "votes:" (with small letter "v") prevented automatic merge. On the other
>> hand I find it more difficult remembering how to call the script than to
>> edit STATUS manually...
>>
>
> I have a feeling that most of us know about the scripts but since some
> months pass between using them, it's seems more expedient in the
> moment to just edit by hand than to find the script and refresh one's
> memory about how to run it.
I generally do:
.
ln -s ../trunk-wc/tools/dist/nominate.pl n
ln -s ../trunk-wc/tools/dist/backport.pl b
.
and then run «./b» to vote, or «./n r42 "Because I wanna!"» to nominate.
Nominating requires the revision and justification to be specified, but
not the logsummary. The intuition for that is that logsummary and the
trunk log message answer the same question ("What does this changeset
do?"), so the former is auto-filled with the first paragraph of the
latter; whereas the justification is the answer to "Why does this
changeset merit being backported to a stable branch?", and hence can't
be filled automatically.
dsahlberg's r1918160 demonstrates the differences nicely: compare its
diff, trunk log message, logsummary, and justification.
Perhaps something in all this could be used to improve the usage
message (if the functionality ends up living in HEAD in one language or
another).
> That can be helped by adding a little bit of documentation at the top
> of STATUS, like:
>
> """
> To add nominations:
> $ tools/backport/nominate.py
>
> To review and cast votes:
> $ tools/backport/vote.py
> """
