On 2020/09/22 7:55, Yasuhito FUTATSUKI wrote: > On 2020/09/21 5:27, Stefan Sperling wrote: >> On Mon, Sep 21, 2020 at 01:18:54AM +0900, Yasuhito FUTATSUKI wrote: >>> On 2020/09/20 23:53, Yasuhito FUTATSUKI wrote:
>>> Parhaps even with this patch, it may not work on Windows system other than >>> UTF-8 code page, because svn_path_cstring_from_utf8() returns just same >>> string as input and system() will interpret with system active code page. >>> (I don't know Windows so much, so I leave it.) >> >> I don't know Windows either. >> >> Perhaps someone else reading this could test the patch? > > The patch itself affect nothing on Windows and macOS environment > because svn_path_cstring_from_utf8() returns just same string as a > input string. So if there is the same issue on Windows environment, > it is need another patch to fix it. So I'll commit this patch if > it is OK on Linux and Unix like OS. I commited the v3 patch in 1882234. I confirmed that on Windows in CP932, both of with and without the v3 patch, it cannot pass the file name to edit. For Windows I confirmed that it can be fixed by using _wsystem() with WCHAR string, so I commited it in 1882235. Cheers, -- Yasuhito FUTATSUKI <futat...@yf.bsclub.org>
