rzo1 commented on code in PR #2119:
URL: https://github.com/apache/stormcrawler/pull/2119#discussion_r3944166908
##########
core/src/main/resources/crawler-default.yaml:
##########
@@ -159,10 +159,14 @@ config:
# - "localhost" / "loopback" (matches InetAddress.isLoopbackAddress())
# - "sitelocal" (matches InetAddress.isSiteLocalAddress())
# - "linklocal" (matches InetAddress.isLinkLocalAddress())
+ # - "anylocal" (matches InetAddress.isAnyLocalAddress())
+ # - "multicast" (matches InetAddress.isMulticastAddress())
+ # A value which is neither of these is a configuration error and stops the
+ # topology from starting.
# Only addresses matching an include rule are fetched (empty means all are
# allowed), addresses matching an exclude rule are always blocked.
# http.filter.ipaddress.include:
- # http.filter.ipaddress.exclude: "localhost,sitelocal,linklocal"
+ # http.filter.ipaddress.exclude:
"localhost,sitelocal,linklocal,100.64.0.0/10,fd00::/8"
Review Comment:
The doc block above now advertises `anylocal` and `multicast`, but the
example does not use them. `fd00::/8` also only covers the locally-assigned
half of ULA, while the comment above says "IPv6 unique-local", which is
`fc00::/7`.
`fc00::/8` is unassigned in practice, so this is completeness rather than an
open hole.
```suggestion
# http.filter.ipaddress.exclude:
"localhost,sitelocal,linklocal,anylocal,multicast,100.64.0.0/10,fc00::/7"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
