Thanks Ayush. To answer your questions:
(1) Checksums are created by Maven. It is in the format for central according to https://issues.apache.org/jira/browse/MNGSITE-378 - we can fix that manually by adding the file name for the artifact (and update release docs). (2) „__files“ is a folder, which is created by OSX. Since I did run the release on OSX, I guess, that this is an artifact. We should check, if we can exclude those folders from the source distribution by adding an exclude to override the default config by ASF parent pom. Gruß Richard > Am 16.09.2024 um 10:41 schrieb Ayush Saxena <ayush...@gmail.com>: > > +1 (Binding) > > * Built from source > * Verified checksums [1] > * Validated Signature > * NOTICE & DISCLAIMER file exist > * Verified Incuabting in name > * Verified source files have apache header > * Verified no code diff b/w git tag & src tar [2] > * Skimmed over the published jars > > Thanx Richard for driving the release. Good Luck!!! > > -Ayush > > [1] The checksum matches but shasum fails, curious like how do we > generate the checksum here: > ``` > ayushsaxena@ayushsaxena 3.1.0-rc1 % shasum -c -a 512 *.sha512 > shasum: apache-stormcrawler-3.1.0-incubating-source-release.tar.gz.sha512: > no properly formatted SHA checksum lines found > ``` > > [2] I saw a directory in the src tar > ``` > apache-stormcrawler-3.1.0-incubating/core/src/test/resources/__files > ``` > It is there in src tar but not in git tag > ``` > drwxr-xr-x 2 ayushsaxena staff 64 Jul 5 00:22 __files > ``` > It seems like an empty directory not a binary, so I don't think it is > problematic, but still why it is there only in src tar > > On Sun, 15 Sept 2024 at 22:33, PJ Fanning <fannin...@apache.org> wrote: >> >> +1 fanningpj (IPMC and PPMC) >> >> * Checked the file names and that downloads work >> * asc and sha512 are valid >> * can compile from source >> * source headers ok >> * only binaries seem to be used for test case inputs >> * nexus published jars look ok >> >> Some nits that I have raised as issues in the issue tracker. >> >> On 2024/09/13 13:40:18 Julien Nioche wrote: >>> Thanks Richard >>> >>> Followed the checklist and ran a crawl with the RC, all good! >>> >>> +1 jnioche (PPMC) >>> >>> On Fri, 13 Sept 2024 at 10:49, Richard Zowalla <r...@apache.org> wrote: >>> >>>> >>>> Hi folks, >>>> >>>> I have posted a 1st release candidate for the Apache StormCrawler >>>> (Incubating) [version] release and it is ready for testing. >>>> >>>> This is the 2nd release under the ASF umbrella. Notably, it contains the >>>> new playwright module, which can be used for >>>> dynamic scraping. >>>> >>>> Thank you to everyone who contributed to this release, including all of >>>> our users and the people who submitted bug reports, >>>> contributed code or documentation enhancements. >>>> >>>> The release was made using the Apache StormCrawler (Incubating) release >>>> process, documented here: >>>> https://github.com/apache/incubator-stormcrawler/blob/main/RELEASING.md >>>> >>>> Source: >>>> >>>> https://dist.apache.org/repos/dist/dev/incubator/stormcrawler/3.1.0-rc1/ >>>> >>>> Tag: >>>> >>>> https://github.com/apache/stormcrawler/releases/tag/stormcrawler-3.1.0 >>>> >>>> Commit Hash: >>>> >>>> 95f80689e029a8c63a7cbf8e2a831c412250f245 >>>> >>>> Maven Repo: >>>> >>>> >>>> https://repository.apache.org/content/repositories/orgapachestormcrawler-1002 >>>> >>>> <repositories> >>>> <repository> >>>> <id>stormcrawler-3.1.0-rc1</id> >>>> <name>Testing StormCrawler 3.1.0 release candidate</name> >>>> <url> >>>> >>>> https://repository.apache.org/content/repositories/orgapachestormcrawler-1002 >>>> </url> >>>> </repository> >>>> </repositories> >>>> >>>> Preview of website: >>>> >>>> https://stormcrawler.staged.apache.org/download/index.html >>>> >>>> Release notes: >>>> >>>> >>>> https://github.com/apache/incubator-stormcrawler/releases/tag/stormcrawler-3.1.0 >>>> >>>> Reminder: The up-2-date KEYS file for signature verification can be >>>> found here: https://downloads.apache.org/incubator/stormcrawler/KEYS >>>> >>>> Please vote on releasing these packages as Apache StormCrawler (Incubator) >>>> 3.1.0 >>>> The vote is open for at least the next 72 hours. >>>> >>>> Only votes from IPMC are binding, but everyone is welcome to check the >>>> release candidate and vote. >>>> The vote passes if at least three binding +1 votes are cast. >>>> >>>> Please VOTE >>>> >>>> [+1] go ship it >>>> [+0] meh, don't care >>>> [-1] stop, there is a ${showstopper} >>>> >>>> Please include your checklist in your vote: >>>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist >>>> >>>> Note: After this VOTE passes on our dev@ list, the VOTE will be brought >>>> to general@ in order to get the necessary IPMC votes. >>>> >>>> Thanks! >>>> Richard >>>
