> On Oct. 10, 2018, 11:26 a.m., Szabolcs Vasas wrote: > > Hi Bogi, > > > > Thank you for improving the patch, it is much more concise now. > > I have ran the tests successfully however I noticed that when I run the > > tests without the S3 generator command the new test fails and does not get > > skipped. > > I am not sure but the ExpectedException could have something to do with the > > failure. > > Can you please check this?
Hi Szabolcs, Thanks, I missed to check this scenario with the new test case. Skip logic works as expected but a null check was missing from the After method. Thank you, Bogi - Boglarka ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/#review209401 ----------------------------------------------------------- On Oct. 10, 2018, 11:59 a.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68712/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2018, 11:59 a.m.) > > > Review request for Sqoop, daniel voros, Fero Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-3376 > https://issues.apache.org/jira/browse/SQOOP-3376 > > > Repository: sqoop-trunk > > > Description > ------- > > Testing the Text and Parquet imports into an external Hive table backed by S3. > > > Diffs > ----- > > src/test/org/apache/sqoop/s3/TestS3ExternalHiveTableImport.java > PRE-CREATION > src/test/org/apache/sqoop/testutil/HiveServer2TestUtil.java > 799370816cccda7578d7c64add6e283d3123e1c8 > src/test/org/apache/sqoop/testutil/S3TestUtils.java > 0e6ef5bf001797aa70a7ad50d261c6fd384222fe > > > Diff: https://reviews.apache.org/r/68712/diff/5/ > > > Testing > ------- > > ./gradlew test -Ds3.bucket.url=<bucket-url> > -Ds3.generator.command=<credential-generator-command> > > > Thanks, > > Boglarka Egyed > >
