----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/ -----------------------------------------------------------
(Updated Oct. 10, 2018, 11:59 a.m.) Review request for Sqoop, daniel voros, Fero Szabo, and Szabolcs Vasas. Changes ------- Removed unnecessary ExpectedException rule, added null check for hiveMiniCluster stopping in After method. Bugs: SQOOP-3376 https://issues.apache.org/jira/browse/SQOOP-3376 Repository: sqoop-trunk Description ------- Testing the Text and Parquet imports into an external Hive table backed by S3. Diffs (updated) ----- src/test/org/apache/sqoop/s3/TestS3ExternalHiveTableImport.java PRE-CREATION src/test/org/apache/sqoop/testutil/HiveServer2TestUtil.java 799370816cccda7578d7c64add6e283d3123e1c8 src/test/org/apache/sqoop/testutil/S3TestUtils.java 0e6ef5bf001797aa70a7ad50d261c6fd384222fe Diff: https://reviews.apache.org/r/68712/diff/5/ Changes: https://reviews.apache.org/r/68712/diff/4-5/ Testing ------- ./gradlew test -Ds3.bucket.url=<bucket-url> -Ds3.generator.command=<credential-generator-command> Thanks, Boglarka Egyed