----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/#review209226 -----------------------------------------------------------
Ship it! Lgtm! It is interesting to see that you ran into the problem that parameterized tests don't support multiple dimensions! In any case, I like the tests as they are now, they are concise enough and descriptive enough. My only concern is documentation, and that it should also cover the kinks and quirks. But I see you've filed a separate Jira for that. src/test/org/apache/sqoop/s3/TestS3ExternalHiveTableImport.java Lines 100 (patched) <https://reviews.apache.org/r/68712/#comment293541> Typo :) e missing from TestCase src/test/org/apache/sqoop/testutil/S3TestUtils.java Lines 136-138 (original), 153-155 (patched) <https://reviews.apache.org/r/68712/#comment293542> This sounds like something we should also mention in the user guide! - Fero Szabo On Sept. 24, 2018, 11:12 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68712/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2018, 11:12 p.m.) > > > Review request for Sqoop, daniel voros, Fero Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-3376 > https://issues.apache.org/jira/browse/SQOOP-3376 > > > Repository: sqoop-trunk > > > Description > ------- > > Testing the Text and Parquet imports into an external Hive table backed by S3. > > > Diffs > ----- > > src/test/org/apache/sqoop/s3/TestS3ExternalHiveTableImport.java > PRE-CREATION > src/test/org/apache/sqoop/testutil/HiveServer2TestUtil.java > 799370816cccda7578d7c64add6e283d3123e1c8 > src/test/org/apache/sqoop/testutil/S3TestUtils.java > 0e6ef5bf001797aa70a7ad50d261c6fd384222fe > > > Diff: https://reviews.apache.org/r/68712/diff/3/ > > > Testing > ------- > > ./gradlew test -Ds3.bucket.url=<bucket-url> > -Ds3.generator.command=<credential-generator-command> > > > Thanks, > > Boglarka Egyed > >
