----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review188652 -----------------------------------------------------------
Hi Chris, Thanks for addressing review findinds in your new patch however there are still numerous changes shown in the Diff because of reformatting. Please revert these so that only your actual changes present in the Diff. Thank you, Bogi src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java Line 86 (original), 91 (patched) <https://reviews.apache.org/r/62653/#comment265672> This is an example of "shown as changed" because of reformatting. - Boglarka Egyed On Oct. 2, 2017, 11:12 p.m., Chris Teoh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62653/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2017, 11:12 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3225 > https://issues.apache.org/jira/browse/SQOOP-3225 > > > Repository: sqoop-trunk > > > Description > ------- > > There were some cases where the FTP listing parser was not used for mainframe > datasets, only the default was used. This caused some datasets to not be seen > by Sqoop as the default parser couldn't find them. This patch addresses this > behaviour where it is used to parse FTP listings for sequential and gdg > datasets on disk and tape, only partitioned datasets are excluded as their > FTP listing looks very different and is handled by the default FTP listing > parser. > > > Diffs > ----- > > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java f61b9838 > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java d87c75df > > > Diff: https://reviews.apache.org/r/62653/diff/5/ > > > Testing > ------- > > Unit testing. > Functional testing on a real mainframe with a previous combined patch. > > > Thanks, > > Chris Teoh > >
