> On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote: > > build.xml, line 897 > > <https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line897> > > > > Why do we need this?
This was added as the version of hadoop that is passed to the build script should be at a minimum of 210 for Phoenix. I have used these system properties in my test cases. > On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote: > > build.xml, line 196 > > <https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line196> > > > > Do we need a profile based mechanism like Accumulo/Hbase/HCat etc? I > > see that 4.6.0 is a later version and may be we need to support 4.4.0 also? I haven't honestly tested with 4.4.0 of phoenix. For now, we can stick with 4.6.0 as it is much stable. > On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote: > > build.xml, line 194 > > <https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line194> > > > > Can we add 098 version separately Sure will do that. Apparently, HBase 098 requires Hadoop 220 . Tests aren't successful for previous versions. Is it ok to add a new Hadoop profile 220 ? > On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote: > > build.xml, line 101 > > <https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line101> > > > > Is this (0.95 to 0.98) required? Since the plan is on having both 0.95 and 0.98, I will go ahead and keep both. - Ravi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42809/#review124725 ----------------------------------------------------------- On March 22, 2016, 3:08 a.m., Ravi Magham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42809/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 3:08 a.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Repository: sqoop-trunk > > > Description > ------- > > Support for importing data onto Apache Phoenix tables > > > Diffs > ----- > > build.xml 97e5502 > ivy.xml d84b88f > ivy/ivysettings.xml 2920c89 > src/docs/user/import.txt fbb32f5 > src/docs/user/phoenix-args.txt PRE-CREATION > src/docs/user/phoenix.txt PRE-CREATION > src/docs/user/validation.txt 27a78e2 > src/java/org/apache/sqoop/SqoopOptions.java ff96280 > src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0 > src/java/org/apache/sqoop/manager/SqlManager.java 768507b > src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0 > src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION > src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION > src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION > src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION > src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43 > src/java/org/apache/sqoop/tool/ImportTool.java ff7b822 > src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION > src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION > src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION > src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/42809/diff/ > > > Testing > ------- > > > Thanks, > > Ravi Magham > >
