----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42809/#review127484 -----------------------------------------------------------
Ship it! Fix the identified changes and ship it. There are two lines with whitespace issues - but I can fix it on commit once the new patch is in - Venkat Ranganathan On March 21, 2016, 8:08 p.m., Ravi Magham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42809/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 8:08 p.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Repository: sqoop-trunk > > > Description > ------- > > Support for importing data onto Apache Phoenix tables > > > Diffs > ----- > > build.xml 97e5502 > ivy.xml d84b88f > ivy/ivysettings.xml 2920c89 > src/docs/user/import.txt fbb32f5 > src/docs/user/phoenix-args.txt PRE-CREATION > src/docs/user/phoenix.txt PRE-CREATION > src/docs/user/validation.txt 27a78e2 > src/java/org/apache/sqoop/SqoopOptions.java ff96280 > src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0 > src/java/org/apache/sqoop/manager/SqlManager.java 768507b > src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0 > src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION > src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION > src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION > src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION > src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43 > src/java/org/apache/sqoop/tool/ImportTool.java ff7b822 > src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION > src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION > src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION > src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/42809/diff/ > > > Testing > ------- > > > Thanks, > > Ravi Magham > >