----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42809/#review120024 -----------------------------------------------------------
Thanks for doing this. If you look at the RB patch, there are lots of lines with tabs and a few with trailing spaces. Can you please fix them and upload. It is probably your IDE that is causing this. Please check your IDE settings Thanks src/java/org/apache/sqoop/SqoopOptions.java (line 2454) <https://reviews.apache.org/r/42809/#comment181384> Tabs instead of spaces src/java/org/apache/sqoop/manager/SqlManager.java (line 674) <https://reviews.apache.org/r/42809/#comment181385> Tabs instead of spaces - trailing spaces src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java (line 66) <https://reviews.apache.org/r/42809/#comment181386> Tabs instead of spaces - Venkat Ranganathan On Feb. 13, 2016, 4:11 p.m., Ravi Magham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42809/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2016, 4:11 p.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Repository: sqoop-trunk > > > Description > ------- > > Support for importing data onto Apache Phoenix tables > > > Diffs > ----- > > build.xml d614d09 > ivy.xml a93d0af > ivy/ivysettings.xml 2920c89 > src/docs/user/import.txt df04157 > src/docs/user/phoenix-args.txt PRE-CREATION > src/docs/user/phoenix.txt PRE-CREATION > src/docs/user/validation.txt 27a78e2 > src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce > src/java/org/apache/sqoop/manager/ConnManager.java d9569c5 > src/java/org/apache/sqoop/manager/SqlManager.java ead581d > src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd > src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION > src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION > src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION > src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION > src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58 > src/java/org/apache/sqoop/tool/ImportTool.java c79e044 > src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION > src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION > src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION > src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/42809/diff/ > > > Testing > ------- > > > Thanks, > > Ravi Magham > >
