RemoLiechti commented on code in PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/62#discussion_r2115470080
##########
src/main/java/org/apache/sling/engine/impl/SlingHttpServletResponseImpl.java:
##########
@@ -220,12 +225,12 @@ public void setStatus(final int sc, final String msg) {
@Override
public void reset() {
- if (!this.isProtectHeadersOnInclude()) {
+ if (!this.isProtectHeadersOnInclude() || isError()) {
super.reset();
} else {
// ignore if not committed
- if (getResponse().isCommitted()) {
- getResponse().reset();
+ if (super.isCommitted()) {
+ super.reset();
Review Comment:
reviews this with @cziegeler , check the new comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
