RemoLiechti commented on code in PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/62#discussion_r2108583045
##########
src/main/java/org/apache/sling/engine/impl/filter/ErrorFilterChain.java:
##########
@@ -118,6 +121,10 @@ public void doFilter(final ServletRequest request, final
ServletResponse respons
return;
}
// reset the response to clear headers and body
+ if (response instanceof SlingHttpServletResponseImpl) {
+ final DispatchingInfo dispatchInfo = new
DispatchingInfo(DispatcherType.ERROR);
+ ((SlingHttpServletResponseImpl)
response).getRequestData().setDispatchingInfo(dispatchInfo);
+ }
Review Comment:
because so far, we do not change the dispatch info but create a new one in
the two other places. There might be no dispatcher info that comes with the
response might be null at that time as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
