RemoLiechti commented on code in PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/62#discussion_r2108578879
##########
src/main/java/org/apache/sling/engine/impl/SlingHttpServletResponseImpl.java:
##########
@@ -220,12 +225,12 @@ public void setStatus(final int sc, final String msg) {
@Override
public void reset() {
- if (!this.isProtectHeadersOnInclude()) {
+ if (!this.isProtectHeadersOnInclude() || isError()) {
super.reset();
} else {
// ignore if not committed
- if (getResponse().isCommitted()) {
- getResponse().reset();
+ if (super.isCommitted()) {
Review Comment:
true, we could also use that, currently points to the same anyway, but would
be cleaner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
