mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to Kafka 2.0 URL: https://github.com/apache/samza/pull/951#discussion_r268890341
########## File path: gradle/dependency-versions.gradle ########## @@ -34,7 +34,7 @@ jodaTimeVersion = "2.2" joptSimpleVersion = "3.2" junitVersion = "4.12" - kafkaVersion = "0.11.0.2" + kafkaVersion = "2.0.1" Review comment: We already pull in `slf4j-log4j12` as part of build time dependency in samza-log4j module. Since we have a direct pinned dependency, I suppose it shouldn't matter. Let me keep an eye for any potential logging issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
