mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to
Kafka 2.0
URL: https://github.com/apache/samza/pull/951#discussion_r267623921
##########
File path:
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala
##########
@@ -301,12 +260,6 @@ class TestKafkaSystemAdmin {
val spec = StreamSpec.createCoordinatorStreamSpec(topic, "kafka")
systemAdmin.createStream(spec)
validateTopic(topic, 1)
- val topicMetadataMap = TopicMetadataCache.getTopicMetadata(Set(topic),
"kafka", metadataStore.getTopicInfo)
- assertTrue(topicMetadataMap.contains(topic))
- val topicMetadata = topicMetadataMap(topic)
- val partitionMetadata = topicMetadata.partitionsMetadata.head
- assertEquals(0, partitionMetadata.partitionId)
- assertEquals(3, partitionMetadata.replicas.size)
Review comment:
Yeah. I tried to keep this by using APIs from `adminClient` and
`adminZkClient`but in vain. I'd have to replicate the logic in the file
`ClientsUtilTopicMetadataStore.scala` that was removed as part of the PR. Since
we no longer have any active code path within our codebase that reads this
data, I chose to remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
