mynameborat commented on a change in pull request #951: SAMZA-2127: Upgrade to
Kafka 2.0
URL: https://github.com/apache/samza/pull/951#discussion_r267623375
##########
File path:
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
##########
@@ -110,15 +110,12 @@ class TestKafkaCheckpointManager extends
KafkaServerTestHarness {
kcm1.stop
// check that start actually creates the topic with log compaction enabled
- val zkClient = ZkUtils(zkConnect, 6000, 6000,
JaasUtils.isZkSecurityEnabled())
- val topicConfig = AdminUtils.fetchEntityConfig(zkClient, ConfigType.Topic,
checkpointTopic)
+ val topicConfig =
adminZkClient.getAllTopicConfigs().getOrElse(checkpointTopic, new Properties())
Review comment:
`adminZkClient` is a very light weight utility wrapper around `zkClient` and
doesn't have any lifecycle methods. However, `ZookeeperTestHarness` parent of
`KafkaServerTestHarness` takes care of managing the lifecycle of zkClient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
