zhangjidi2016 commented on a change in pull request #57:
URL: https://github.com/apache/rocketmq-dashboard/pull/57#discussion_r778496193
##########
File path:
src/main/java/org/apache/rocketmq/dashboard/service/impl/ConsumerServiceImpl.java
##########
@@ -296,14 +296,22 @@ public boolean apply(MessageQueue o) {
@Override
public boolean deleteSubGroup(DeleteSubGroupRequest deleteSubGroupRequest)
{
+ Set<String> brokerSet =
this.fetchBrokerNameSetBySubscriptionGroup(deleteSubGroupRequest.getGroupName());
+ List<String> brokerList = deleteSubGroupRequest.getBrokerNameList();
+ boolean deleteInNsFlag = false;
+ // If the list of brokers passed in by the request contains the list
of brokers that the consumer is in,
+ // delete RETRY and DLQ topic in namesrv
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
