zhangjidi2016 commented on a change in pull request #57:
URL: https://github.com/apache/rocketmq-dashboard/pull/57#discussion_r778494920
##########
File path:
src/main/java/org/apache/rocketmq/dashboard/service/impl/ConsumerServiceImpl.java
##########
@@ -312,14 +320,16 @@ public boolean deleteSubGroup(DeleteSubGroupRequest
deleteSubGroupRequest) {
return true;
}
- private void deleteResources(String topic, String brokerName, ClusterInfo
clusterInfo) throws Exception {
+ private void deleteResources(String topic, String brokerName, ClusterInfo
clusterInfo, boolean deleteInNsFlag) throws Exception {
mqAdminExt.deleteTopicInBroker(Sets.newHashSet(clusterInfo.getBrokerAddrTable().get(brokerName).selectBrokerAddr()),
topic);
Set<String> nameServerSet = null;
if (StringUtils.isNotBlank(configure.getNamesrvAddr())) {
String[] ns = configure.getNamesrvAddr().split(";");
nameServerSet = new HashSet<>(Arrays.asList(ns));
}
- mqAdminExt.deleteTopicInNameServer(nameServerSet, topic);
+ if (deleteInNsFlag) {
Review comment:
Yes, these lines of code is covered . The reason for the decrease in
coverage this time is that the code modified by this patch(#59) is not covered.
Since it is a different branch, the single test cannot be directly added this
time, and it will be added in the subsequent submit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
