zhangjidi2016 commented on a change in pull request #57:
URL: https://github.com/apache/rocketmq-dashboard/pull/57#discussion_r777818033



##########
File path: 
src/test/java/org/apache/rocketmq/dashboard/controller/ConsumerControllerTest.java
##########
@@ -182,6 +182,8 @@ public void testDelete() throws Exception {
         final String url = "/consumer/deleteSubGroup.do";
         {
             doNothing().when(mqAdminExt).deleteSubscriptionGroup(any(), 
anyString());
+            doNothing().when(mqAdminExt).deleteTopicInBroker(any(), 
anyString());

Review comment:
       In unit tests, all RPC interfaces involved in interacting with RocketMQ 
used mocks for data return,and this two delete interface methods return void




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to