Yes, there may have multiple clients request the HC at the same time in the AutoFailover case, so we should add some cache to reduce broker load.
On 2022/06/22 12:55:49 Enrico Olivelli wrote: > Il giorno mer 22 giu 2022 alle ore 14:45 Cong Zhao > <zhaoc...@apache.org> ha scritto: > > > > Hi Enrico, > > > > > Also, I would like to understand in which usecase you can use the > > > binary endpoint and not the HTTP endpoint. > > > > We can't use the HTTP endpoint when the client did not have the admin auth > > to do a health check. but we need it in some cases such as auto failover on > > the client-side > > (https://github.com/apache/pulsar/pull/13316#discussion_r773313991) > AutoFailover is a valid use case for me. > Thanks > > > > > > Health Check is good for scripts and for probes, I don't expect a > > > "client application" to run the HC > > > > Adding a health check API to the client-side just to make it easier to use > > this feature, this check still works on broker. > > makes sense, but usually the HC, like in k8s or in other environments > is run every X seconds and usually not concurrently > > if you have multiple (tens? hundreds?) of Pulsar clients that require > the HC, this will be a big problem, > is this the reason why you want to add some cache to the response of the HC ? > > Enrico > > > > > > > > On 2022/06/22 10:19:52 Enrico Olivelli wrote: > > > I believe that this proposal is too broad. > > > > > > the PIP reads about: > > > - adding HEALTHCHECK to the binary protocol > > > - add a HEALTHCHECK cache on the broker > > > > > > Also, I would like to understand in which usecase you can use the > > > binary endpoint and not the HTTP endpoint. > > > > > > Health Check is good for scripts and for probes, I don't expect a > > > "client application" to run the HC > > > > > > Can you please illustrate some practical use cases? > > > > > > Enric > > > > > > Il giorno mer 8 giu 2022 alle ore 05:22 zhaocong <zhaoc...@apache.org> > > > ha scritto: > > > > > > > > Hello Pulsar Community, > > > > > > > > > > > > Here is a PIP to introduce the HEALTH_CHECK command in the binary > > > > protocol. > > > > I look forward to your feedback. > > > > > > > > > > > > PIP: https://github.com/apache/pulsar/issues/15859 > > > > > > > > > > > > Thanks, > > > > > > > > Cong Zhao > > > >
