Thanks for your review, I will submit the v2 patches soon. > On Aug 30, 2016, at 1:14 AM, Guru Shetty <g...@ovn.org> wrote: > > > On 28 August 2016 at 02:05, nickcooper-zhangtonghao > <nickcooper-zhangtong...@opencloud.tech > <mailto:nickcooper-zhangtong...@opencloud.tech>> wrote: > This patches provide the command line to create load-balancer and add > the unit tests. > > Thank you for working on this. I have a few higher level comments. > 1. I do not see the 2nd patch in the series. Neither in the mailing list or > in the patchwork. > 2. You should merge the 3 patches into one in your next revision. Related > code change, man page change and unit test should be in a single commit. > 3. I want the ability to have load-balancers created independently. i..e I > don't want to wait till I add it to a switch. This helps in creating a > load-balancer and adding it to multiple switches. Also, I have code sent out > for review to add the load-balancer to the gateway router too. So I suggest > waiting till that gets in to see what is a nice way to add ovn-nbctl commands. > 4. I think the system tests will fail with this patch series. Please run: > make check-kernel TESTSUITEFLAGS="-k ovn"
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
