It's ok with me to skip the tests for the moment, but please add a comment why are you skipping them i.e. "echo $! gives shell pid instead of parent process"
Otherwise: Acked-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> > -----Mesaj original----- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > Trimis: Wednesday, July 6, 2016 3:38 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V6 08/17] python tests: Skip python tests on > Windows where POSIX pid is used > > There is a difference between POSIX pid and Windows pid, not all the time > are equal. > On Windows when a python script is started, a sh command is triggered as > the parent for script. So when we try to get the daemon pid with 'echo $!', > this will get the pid of sh not of python.exe as expected. > Also the 'kill' command expects a POSIX pid, not the Windows pid written by > the python daemons in pid file. > > Signed-off-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com> > --- > V2: No changes > V3: No changes > V4: No changes > V5: No changes > V6: No changes > --- > tests/daemon-py.at | 7 +++++++ > tests/jsonrpc-py.at | 3 +++ > 2 files changed, 10 insertions(+) > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
