As a personal preference I think the comment: > + # This test won't work as-is on Windows because Windows doesn't allow > + # files that are open to be renamed. is sufficient.
Acked-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> > -----Mesaj original----- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > Trimis: Wednesday, July 6, 2016 3:39 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V6 16/17] tests: Skip vlog tests that try to move > opened file > > On Windows if a file is opened by an application for writing, we cannot move > it until all handles to that file are closed. > > Signed-off-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com> > --- > V3: Initial commit > V4: No changes > V5: No changes > V6: Removed code that disables 'vlog/close' tests. > --- > tests/vlog.at | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tests/vlog.at b/tests/vlog.at index 3a3d435..7f3004d 100644 > --- a/tests/vlog.at > +++ b/tests/vlog.at > @@ -115,6 +115,9 @@ m4_divert_pop([PREPARE_TESTS]) AT_SETUP([vlog - > vlog/reopen - C]) # This test won't work as-is on Windows because Windows > doesn't allow # files that are open to be renamed. > +# Also, on Windows it is not possible to initiate move file operation # > +while it is opened, and when the file is closed to expect it is # also > +removed, like on Linux. > AT_SKIP_IF([test "$IS_WIN32" = "yes"]) > on_exit 'kill `cat test-unixctl.pid`' > > @@ -148,6 +151,12 @@ AT_CLEANUP > > m4_define([VLOG_REOPEN_PYN], > [AT_SETUP([vlog - vlog/reopen - $1]) > + # This test won't work as-is on Windows because Windows doesn't allow > + # files that are open to be renamed. > + # Also, on Windows it is not possible to initiate move file operation > + # while it is opened, and when the file is closed to expect it is > + # also removed, like on Linux. > + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) > AT_SKIP_IF([test $2 = no]) > on_exit 'kill `cat test-unixctl.py.pid`' > > -- > 2.7.2.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
